Picture thought to be downloaded from the Internet even though it is not

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons

https://commons-app.github.io/

Apache License 2.0

1.03k stars 1.24k forks source link

Picture thought to be downloaded from the Internet even though it is not #2704

Open nicolas-raoul opened 5 years ago

nicolas-raoul commented 5 years ago

Steps to reproduce:

Install this app: https://play.google.com/store/apps/details?id=btfactor.realhdrcamera
Take a picture with it
Try to upload it
The warning about pictures downloaded from the Internet pops up

Example picture: https://commons.wikimedia.org/wiki/File:Omotesando_station_exit_2_at_night.jpg

To do

Try to reproduce the issue
Find out whether fixing it is possible

Thanks!

maskaravivek commented 5 years ago

This issue would require some investigation and also a fair understanding of EXIF and IPTC.

Am not sure if this is really a beginner friendly issue.

nicolas-raoul commented 5 years ago

@maskaravivek To me, "beginner-friendly" means that the issue does not require deep knowledge of our project. The present task is doable without even looking at the source code of our app, so that's why I tagged it, even though I agree that it requires technical skills (using an hexadecimal editor and looking up documentation).

noahwalugembe commented 5 years ago

Yes the image contain EXIF DATA blow { Camera make : UMIDIGICamera model : A3Date/Time :2019/03/23 00:20:42 Resolution : 2592 x 4608 Flash used : NoFocal length : 3.5mmExposure time : 0.030 s (1/33)Aperture : f/2.0ISO equiv. : 283Whitebalance : AutoMetering Mode : center weight

} Ultimate_HDR_Camera_Original_20190323_002035

vanshikaarora commented 5 years ago

@nicolas-raoul I couldn't reproduce the Issue. Have you made any specific changes to the image taken through that App.

Also I have verified the response for EXIF:

Taken from "Ultimate HDR Camera" App

JPEG Directory
EXIF IFDO Directory
EXIF SubIFD Directory
Interoperability Directory
EXIF Thumbnail Directory
Huffman Directory
File Type Directory
File Directory

Taken from phone's camera

JPEG Directory
EXIF IFDO Directory
EXIF SubIFD Directory
Interoperability Directory
EXIF Thumbnail Directory
Huffman Directory
File Type Directory
File Directory
GPS Directory

The only difference here being of the GPS Directory and as per #2581. I have considered the directories

EXIF IFDO Directory
EXIF SubIFD Directory
EXIF Thumbnail Directory as confirmation for images taken via phone's camera. Hence the issue is not with this. @nicolas-raoul can you tell if there is any specific change that you have made to the image due to which your EXIF directories are lost?

nicolas-raoul commented 5 years ago

Thanks @noahwalugembe and @vanshikaarora for checking! https://commons.wikimedia.org/wiki/File:Omotesando_station_exit_2_at_night.jpg is the exact image for which that happened. I will try again and let you know :-)