search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.03k stars 1.23k forks source link

App should not clutter download folder with log files #2968

Open simon04 opened 5 years ago

simon04 commented 5 years ago

/sdcard/Download/logs/prod/CommonsAppLogs.0.log

It's annoying to have logging stuff in my download folder when I want to keep this folder clean.

Use the corresponding data/ folder instead.

neslihanturan commented 5 years ago

Thanks for letting us @simon04

nixxcode commented 5 years ago

@neslihanturan Hi there, is this issue still up for grabs for a newcomer?

I can see that some work was done under #2974, but that issue is still open, while this issue is still marked as open and unassigned.

Thank you.

neslihanturan commented 5 years ago

Please don't rely on labels directly. We sometimes forget changing them. The pull request looks good to me, possibly this issue will be solved after pull request is tested. So I would suggest checking for another issue. Sorry for the inconvenience.

nicolas-raoul commented 5 years ago

@nixxcode Thanks, please let us know if you find any other mislabelled issue :-)

nixxcode commented 5 years ago

My pleasure, glad I could help!

shankarpriyank commented 1 year ago

@nicolas-raoul I would like to work on this

nicolas-raoul commented 1 year ago

@shankarpriyank raised an important question on the PR, about what should be the ideal behavior.

The two important features are:

If these two features work correctly even without writing logs to a local file, then I would say we do not need to write logs to a local file.

shankarpriyank commented 1 year ago

The send log file is working fine and on my device it is not making saving anything in the device