search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.01k stars 1.19k forks source link

Improve Kotlin conversion of Achievement Models #3510

Open macgills opened 4 years ago

macgills commented 4 years ago

Data classes (preferably completely immutable) should be leveraged and there shouldn't be empty constructors

VitalyVPinchuk commented 4 years ago

Hello Is it suitable for beginners? If so, I'd like to work on it but some clarification and guidance needed.

macgills commented 4 years ago

It should be okay, basically the problem is that the models were converted automatically and then not given a manual pass. This PR did a good job but was superseded.

elemcraft commented 5 months ago

Hello, is anyone still working on this issue? Can I take this issue?

nicolas-raoul commented 5 months ago

@elemcraft It is yours, thanks! :-)

nicolas-raoul commented 3 weeks ago

@elemcraft I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)