commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
995 stars 1.18k forks source link

Ambiguities on nearby map marker #3534

Open neslihanturan opened 4 years ago

neslihanturan commented 4 years ago

Summary: Recently I discovered a weird issue. Sometimes there are two different wikidata items with same labels (yes this is possible for wikidata, the unique id is entity id). Firstly they looks non useful on the map, see two different Ataşehir label, one is for the district, the other is for municipality building.

Then I recognized this issue also causes a bug. As you can see from the map, both of them are green, but only one of them has the image attribute.

318anushka commented 4 years ago

} else if (!place.pic.trim().isEmpty()) { vectorDrawable = VectorDrawableCompat.create( // Means place has picture getContext().getResources(), R.drawable.ic_custom_map_marker_green, getContext().getTheme() );

@neslihanturan can you tell me what info does pic field contain? its a string but how do we update its value.

neslihanturan commented 4 years ago

It contains Property:P18 of related wikidata item for this place. https://www.wikidata.org/wiki/Property:P18