Problem at displaying .svg files

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons

https://commons-app.github.io/

Apache License 2.0

1.02k stars 1.23k forks source link

Problem at displaying .svg files #3678

Open neslihanturan opened 4 years ago

neslihanturan commented 4 years ago

Summary: When we clicked to any .svg item on contributions list, Media Details appears as expected at first. It gets the required height from the image. Then after 2 second, image disappears and we look at a blank container with image sizes instead.

Not: If you don't have any .svg images uploaded, exploare tab has the same issue too. Just search for key svg and you will get example images to reproduce this bug.

sivaraam commented 4 years ago

I believe this is the reason that the icon shown for the audios that I've uploaded to Commons (not using the app, of course) disappears after a few seconds:

Screenshot of media details when icon is shown
Screenshot of media details when icon is not shown

I observe this in the app I built for testing PR #3505.

neslihanturan commented 4 years ago

I checked out commit "fcd2867d26efb3aa9310d677ff4b350f19a3bbf3" and can verify this issue is not related with #3505

SaumiaSinghal commented 4 years ago

Hi @neslihanturan! I think the reason behind this is SVG images are not supported by fresco. It is mentioned here. However, fresco allows using custom decoders for SVG formats, as given in the docs. I would like to work on this issue.

sivaraam commented 4 years ago

@SaumiaSinghal You can take this up.

nicolas-raoul commented 2 months ago

@SaumiaSinghal I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)