search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.03k stars 1.23k forks source link

Add some spacing on the "About" view #405

Closed tobias47n9e closed 7 years ago

tobias47n9e commented 7 years ago

On my phone there is no space between the text and the edge of the screen. I would be nice to have the usual 5 to 20px left and right. Might be a good issue for a new contributor. Do we have a tag for that?

screenshot_2017-03-07-17-16-41

domdomegg commented 7 years ago

I quite like for-beginners or entry-level

I think it's a great idea to create this tag - help get us some more contributors. We should then add the project to lists like Awesome-for-beginners or up-for-grabs

misaochan commented 7 years ago

Good idea! Done :) Please feel free attach this tag to any other issues that you guys feel would suit, too.

maskaravivek commented 7 years ago

Contributors who are still relatively new to the codebase should feel free to grab these issues, right?

misaochan commented 7 years ago

Sure, I think anyone should feel free to tackle any open issue that they wish to. From my point of view, the beginners tag will make it easier for a newbie to find an easy task when he arrives, but I don't think we should "reserve" issues solely for that occasion. Besides, new issues pop up all the time anyway. :)

nicolas-raoul commented 7 years ago

@misaochan "for beginners" sounds rather exclusive indeed. Some might feel bad implementing a task marked "for beginners", it feels a bit like stealing cotton candy from a kid at Disneyland. To avoid this, how about maybe renaming the tag "beginner friendly"? By the way, creating this tag was a great idea I think :-)

misaochan commented 7 years ago

Haha good point, done!