search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.02k stars 1.21k forks source link

[Bug]: Only one category shows for a depicted item if it has several values on P373 #4895

Open Ainali opened 2 years ago

Ainali commented 2 years ago

Summary

I noticed on Q636666 that it did not show the category I expected. It turns out that it has two values on P373 and the one that unfortunately is hard to interpret for me is chosen in the app.

Steps to reproduce

  1. Upload an image
  2. In depicts, select an item with several values on P373
  3. In categories, see that only one of them is shown

Expected behaviour

I would like to see all values as suggested categories.

Actual behaviour

The app suggests one of the categories, not all.

Device name

Samsung Galaxy S10

Android version

Android 12

Commons app version

3.1.1~1c9267ca0

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

No response

nicolas-raoul commented 2 years ago

Interestingly the DepictedItem class already has commonsCategories: List<CategoryItem>, we should verify that:

Ainali commented 2 years ago

I made this screencast:

https://user-images.githubusercontent.com/5566159/158545266-d4f06992-6a3d-4fe2-a8a9-13969e7d8314.mp4

Interestingly it shows a category Ventura (ship), which doesn't exist. The name of the other category on Wikidata which exists on Commons, and the one I expected, is Ventura (ship, 2008).

zihanpan commented 1 day ago

Hi, I’m part of a group of 4 working on a university assignment. Could we please be assigned this issue to work on?

nicolas-raoul commented 1 day ago

@zihanpan It is yours, thanks! :-)