commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
998 stars 1.18k forks source link

[Bug]: Parameter name "caption" and resue of caption as file name are suboptimal #4967

Open pigsonthewing opened 2 years ago

pigsonthewing commented 2 years ago

Summary

Use of the term "caption" is ambiguous. The use of the caption for the filename is harmful.

This is especially problematic for sets of images, where the filenames, but not captions, require disambiguation (example 01.jpg, example 02.jpg, etc.)

Steps to reproduce

n/a

Expected behaviour

Users should be asked for an image (file) name; and then whether they wish to use that as the caption (or vice versa).

If they do not they, should be prompted to enter a caption separately,

Actual behaviour

Users are asked to enter a caption. This is then also used as the file name.

Device name

Nord Plus One

Android version

Android 11

Commons app version

3.1.1~1c9267ca0

Device logs

No response

Screen-shots

No response

Would you like to work on the issue?

Prefer not

nicolas-raoul commented 2 years ago

Hi Pigsonthewing, nice to hear from you! I beg to differ on the necessity to ask users to type a technical filename, especially on a tiny keyboard, but probably also on desktop. If the best imaginable captions for two pictures are the exact same caption, then there is no harm in having these two pictures use the same technical filename plus an identifiable technical filename suffix. Or if there actually is harm, I would be happy to see a past real-life example so that we can discuss it further. Thanks for your feedback!

pigsonthewing commented 2 years ago

Your reply assumes that "the best imaginable captions" are also the best imaginable file names. This is not the case.

All my file names, for example, are in the format [subject] - [date] - Andy Mabbett - [number]. At present, when I enter such file names, the app also uses them as captions.

I posit that most images on Commons do not us the same text for file name and caption. Indeed, if they did, we would not need two parameters.