[Bug]: Deletion requests are added to the log with the date written with user's native number system instead of with Arabic numbers

[Jonteemil]

Summary

When the user's native number system is another than Arabic (0-9), any user nominating a file or any other page for deletion add these to the logs with the date written in their number system, for example for example Commons:Deletion_requests/২০২৩/০৭/০৬. And here are the rest I've found. In these pages the pattern is the same but instead of Arabic numbers, there are two with Bengali numbers and the rest with Persian Arabic numbers. The creation of these pages all have the //android app edit// tag and the users probably have another number system than the Arabic one 1-9 resulting in non-Arabic numbers incorrectly being used. So instead of these users adding the deletion request to the normal logs, they add it to the log based on their number system.

Steps to reproduce

Not having the app or an Android myself I would suspect the way to reproduce would be:

1. Have a native number system other than Arabic (i.e. Bengali och Persian Arabic)
2. Open the app
3. Nominate a page for deletion

Expected behaviour

The deletion request is transcluded to the log based on Arabic numbers no matter what native number system the user has, so for today it's Commons:Deletion_requests/2023/08/07

Actual behaviour

The deletion request is transcluded to the log based on the user's native number system, so Commons:Deletion_requests/2023/08/07 if it's Arabic, Commons:Deletion_requests/۲۰۲۳/۰۸/۰۷ if it's Persian Arabic and Commons:Deletion_requests/২০২৩/০৮/০৭ if it's Bengali.

Device name

-

Android version

-

Commons app version

-

Device logs

-

Screen-shots

-

Would you like to work on the issue?

Prefer not

[nicolas-raoul]

Thanks for spotting and reporting this!

[whym]

The date seems to be in the default locale indeed. So the fix should be using English or something similar instead. https://github.com/commons-app/apps-android-commons/blob/a620cc9de686687e160ce51c373b10a0886c7421/app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.java#L95-L96

• What might be more complicated is finding a way to properly unit-test it. Do we need to use ArgumentCaptor perhaps?
• Do we want to use Locale.ENGLISH or Locale.ROOT? (I see both in other date-related things in the code.)

[safan41]

I can see what works best to allow Bengali numbers to work better.