Blockers for 4.2.0 release

[nicolas-raoul]

Any blockers for 4.2.0? Feel free to add if I missed something.

Must fix:

• [x] #5323 prodRelease build error
• [x] https://github.com/commons-app/apps-android-commons/issues/5273 On a fresh install, the location permission request dialog opens as expected but the "Turn on location?" dialog does not open.
• [x] https://github.com/commons-app/apps-android-commons/issues/5303 Crash on lowest supported API 21. Maybe increment minSdk to 23?

Would be much better to fix, but not a blocker either:

• [x] #5342
• [x] #5339
• [x] https://github.com/commons-app/apps-android-commons/issues/5305 Annoying UX
• [x] #5321
• [x] https://github.com/commons-app/apps-android-commons/issues/5324
• [x] #5212

[nicolas-raoul]

@sivaraam I believe all blockers are fixed. How about pushing a release to our beta testers? :-)

[sivaraam]

There's a regression in Ritika's changes that's discussed in https://github.com/commons-app/apps-android-commons/issues/5273#issuecomment-1732990195

I think it would be nice to see the fix for that before the release? It's resulting in the in-app camera upload not opening when location is turned off.

[nicolas-raoul]

@sivaraam I think all blockers are fixed now, there are a few things that are not polished but nothing that justifies holding back the greatness of this new version from our users, I believe. :-)

[sivaraam]

Sure. Let me look into pushing a release over the weekend. 👍🏼

[sivaraam]

Reg. the release. I've created the tag v4.2.0 and included the release notes for the same. Let me know in case I've missed to include anything in the release notes.

I'm facing some odd issues with building the release variant of the app. Somehow it seems like Proguard doesn't work with Java 11 all of a sudden (it says it only supports Java 10 max.). I'm unable to build the data-client when switching to Java 8. Not sure about the cause of this. @nicolas-raoul Feel free to push a beta release if you could do so. Otherwise, I'll look into the root-cause of this and push the beta soon.

Note: It's a bit sad that the CI still fails. It would be nice if we're able to figure out the reason behind the failure of the same. I suppose it is fine if we skip that for the beta release, at least. We should definitely get it back to shape for the production release.

[mnalis]

Note: It's a bit sad that the CI still fails

• (ref: https://github.com/commons-app/apps-android-commons/issues/5245)

[sivaraam]

After crossing some hurdles with getting the production APK (as observed via conversations at #5323 ), pushed out the v4.2.0 beta release for review today. The changes are available in the v4.2.0-beta tag which points at a commit from the v4.2.0-release branch.

PS: I've deleted the previous v4.2.0 tag as it didn't contain code that was in releasable state.

[mnalis]

PS: I've deleted the previous v4.2.0 tag as it didn't contain code that was in releasable state.

Great to see progress on long awaited release @sivaraam!

Though, I'd highly advise against reusing v4.2.0 tag at least (go with v4.2.1 for actual working release). Because, git won't overwrite existing tags in other forks by default, same tag for different commits would also cause all kind of logistic problems trying to report bug or trace where exactly it happened, it might cause issues with autobuilders (e.g. will f-droid build catch the new release if tag remains the same?) etc. And nothing good would come out from reusing v4.2.0 tag.

(I probably wouldn't have even removed the tag, just marked it as buggy -- as realistically, every .0 release is kind-of expected to be at least somewhat buggy anyway :smiley_cat: ; no need to stress about it. But it is also OK if tag is removed, just let's not reintroduce such "burnt" tag later)

[sivaraam]

That's a good point @mnalis! I'll avoid deleting the tag in future and make sure push out actual prod using a different tag 👍🏼

PS: I'll try and push out that v4.2.0 tag as it used to be for reference purposes, if possible.

[sivaraam]

For the note, I've pushed out the deleted v4.2.0 again and released it as a broken version. The v4.2.0-beta has the actual working code.

[nicolas-raoul]

We now have 166 users on the 4.2.0 beta, and still zero ANR/crash for that version :-)

[nicolas-raoul]

@sivaraam Srishti fixed the unit tests, I replaced the Mapbox key, we can now consider that there are no blockers. :-) How about releasing a new beta, then upgrade to production for 10% of the users 24 hours later?

[sivaraam]

Tagged v4.2.1 and pushed the same for testing 👍🏼

[nicolas-raoul]

Only 2 ANR (Application Not Responding) and 1 crash so far, for all 4.2.x beta versions, each affecting 1 user:

All of these 3 seem to have also happened recently in the production version, so they are not new bugs:

It looks pretty good to me. How about releasing now? :-)

[sivaraam]

Makes sense, Nicolas. I've sent the release for review 👍🏼

[sivaraam]

Makes sense, Nicolas. I've sent the release for review 👍🏼

Just wanted to update that the release has been published successfully. So, closing this one :-)

[nicolas-raoul]

Wonderful, thanks all and especially @RitikaPahwa4444 thanks to whom this version is so reliable!