search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
985 stars 1.18k forks source link

Enhancement: Migrate from Views to Compose #5582

Open AbdhilahiRWabwire opened 4 months ago

AbdhilahiRWabwire commented 4 months ago

What is the user problem or growth opportunity you want to see solved?

There are Views in this application. Users of Views should migrate to Compose.

How do you know that this problem exists today? Why is this important?

There are Views that I would like to migrate to Compose. Migration to KSP complete.

Who will benefit from it?

The entire team and application.

Anything else you would like to add?

Jetpack Compose is the migration that is recommended by the Android and Kotlin teams.

psh commented 4 months ago

Compose is really nice, but I think we need to get through the current migration away from Butterknife and synthetic imports before taking on a large refactor like that. Also, how well do those tools play with a (mostly) Java codebase like this app has?

AbdhilahiRWabwire commented 4 months ago

All Kotlin tools are interoperable with Java. Migrating from Views to compose can be done 1 View at a time. Also Compose will allow us to remove:

Replacing them with:

Update: I am working on implementing this. I am preoccupied with other applications but I am planning a pivot.