search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1k stars 1.18k forks source link

When "Show already actioned pictures" disabled, Custom picker does not check uploaded-or-not status for never seen pics #5649

Open nicolas-raoul opened 5 months ago

nicolas-raoul commented 5 months ago
  1. Reset the app
  2. Download https://upload.wikimedia.org/wikipedia/commons/4/4c/Bar-bellied_Pitta.jpg
  3. Start the app
  4. Open custom picker
  5. Tap your "Camera" album (not "Download")
  6. Disable "Show already actioned pictures"
  7. Go back
  8. Tap your "Download" folder
  9. Problem: tHe Pitta pic shows up, even though it is already on Commons.

It seems like the app only verifies checksums when "Show already actioned pictures is enabled.

rohit9625 commented 5 months ago

It's barely repeatable for me. At first, it behaved just like you described, but in the second and all after trials, it just worked like it needed to be. Even after show actioned pictures was disabled, the image didn't show up. That means the app verifies the checksum when that switch is disabled.

nicolas-raoul commented 5 months ago

Example on latest main branch, even though "show already actioned images" is disabled, the already uploaded "pachinko" picture is shown. Then after enabling the switch the app finally does the proper checksum API call.

https://github.com/commons-app/apps-android-commons/assets/99590/a1a3a730-3625-4ecd-ad91-7cb74b183e08