Custom picker: Allow deeper zoom

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons

https://commons-app.github.io/

Apache License 2.0

1.03k stars 1.24k forks source link

Custom picker: Allow deeper zoom #5701

Open nicolas-raoul opened 7 months ago

nicolas-raoul commented 7 months ago

Steps to reproduce:

https://github.com/commons-app/apps-android-commons/assets/99590/abc58816-cf18-4896-bae0-872f1520ee2e

From that screen it is difficult to remember what the picture shows, here is a picture zoomed as deep as possible (on mobile it appears so small that it is impossible to read):

The same picture can be zoomed in much deeper using Google Photos' gallery app:

Similar but different: #1500

rohit9625 commented 7 months ago

I want to work on this task 😀

nicolas-raoul commented 3 months ago

@rohit9625 I unassign for now, but if you are you still working on this, please let us know. If no answer, someone else may be assigned to it. Thanks a lot. :-)

mnalis commented 3 months ago

See idea in linked https://github.com/commons-app/apps-android-commons/issues/5789:

Perhaps we could just call external default gallery/image viewer app (via intent) to display that picture on long-press? That would be much faster, fix the related zoom bug, give user the choice, and probably reduce the code.

mnalis commented 3 months ago

Also, panning doesn't seem to work in zoomed image in Custom picker... Hopefully move to Jetpack Compose mentioned in https://github.com/commons-app/apps-android-commons/issues/5789#issuecomment-2307404397 might fix that too