search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
976 stars 1.18k forks source link

Allow changing app language via System > Languages > App Languages #5755

Open nicolas-raoul opened 2 weeks ago

nicolas-raoul commented 2 weeks ago

Android has a standard way to change an app's language:

Screenshot 2024-06-11 at 22 16 54

You can only change the language for apps that support language selection

This does not seem to be possible for our app, it is not in the list.

If that can make implementation of this feature easier, the App user interface language item in our own Settings can be removed.

krishnagjsForGit commented 1 week ago

Can I work on this issue ?

sivaraam commented 1 week ago

If that can make implementation of this feature easier, the App user interface language item in our own Settings can be removed.

I could understand that this would be good thing to support but I believe this is Android 14 specific feature. So, I don't think we could remove the "App user interface language" in the app's Settings just yet. We can get around to it at a later point in time, I suppose 🙂

nicolas-raoul commented 1 week ago

@sivaraam Ah yes, removing will have to wait a good number of years. :-)

mnalis commented 3 days ago

Note that such android-level per-app language chooser might have several problems (some languages, required API level, translation implementation details etc). See https://github.com/streetcomplete/StreetComplete/pull/5623#issuecomment-2181107764 for issues encountered with implementing idea in StreetComplete OSM app (probably not all apply to Commons app, but some might).

sivaraam commented 2 days ago

Thank you for sharing @mnalis ! That does seem like something to be aware of while adding support for this. 👍🏼