commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.03k stars 1.23k forks source link

Long-press on a folder to reveal a menu offering folder operations #5810

Open nicolas-raoul opened 3 months ago

nicolas-raoul commented 3 months ago

The app has 3 ways to upload new pictures, one of them is the "custom picker". The custom picker has an activity that shows a list of folders:

Screenshot_20241009-122706.png

The present issue is about that custom picker's folders list activity.

The idea is to implement long-press on a folder to reveal a menu offering folder operations:

Phase 1:

Phase 2:

Phase 3:

rohit9625 commented 3 months ago

These use cases are very good but I don't think the user wants to open the folder in another app when the user can open it just by clicking. However, other features are great :)

nicolas-raoul commented 3 months ago

Opening the folder in a file manager may reveal other files, such as videos (which can be uploaded via other means), and possibly memo text files which might add useful context to the pictures.

rohit9625 commented 3 months ago

Okay, now I got it :+1:

LachlanMajor commented 1 month ago

Hi, Can I please be assigned this issue

rohit9625 commented 1 month ago

Well currently the custom selector is in xml and I am working on migrating it to the jetpack compose. So, any changes will be redundant as for now. If you want to work on this feature then you can do so after the migration. I will open a draft PR for that shortly.

Kindly look for issues unrelated to custom selector.

What do you think @nicolas-raoul ?

nicolas-raoul commented 1 month ago

@rohit9625 Sounds good! Would you mind pinging LachlanMajor here after the merge? :-)

rohit9625 commented 1 month ago

Sure, I will ping @LachlanMajor after migration. 🙂

nicolas-raoul commented 1 month ago

@LachlanMajor Feel free to pick another issue meanwhile. Thanks! 🙂

LachlanMajor commented 1 month ago

Yeah thanks Ill look for another one to do instead.