search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.03k stars 1.23k forks source link

Localization: fix incorrect Unicode for space after bullet points in French language #5824

Closed rohit9625 closed 2 months ago

rohit9625 commented 2 months ago

Description (required)

Fixes #5821

What changes did you make and why? Just a small fix for Unicode of space character

Tests performed (required)

Tested prodDebug on Samsung A14 with API level 34.

Screenshots (for UI changes only) None

nicolas-raoul commented 2 months ago

Just a small piece of advice: I would recommend creating branches on your local repository, such as issue5821_bullets, that would allow you to work on several tasks in parallel, as well as prevent possible confusion (for instance I already have a rohit9625-main branch on my local repository but it contains a different fix). Thanks a lot! 😃

nicolas-raoul commented 2 months ago

This pull request solves the issue: Screenshot_20240909-165822_Commons

However, this file will get overwritten the next time translations are pulled from TranslateWiki.

rohit9625 commented 2 months ago

Just a small piece of advice: I would recommend creating branches on your local repository, such as issue5821_bullets, that would allow you to work on several tasks in parallel, as well as prevent possible confusion (for instance I already have a rohit9625-main branch on my local repository but it contains a different fix). Thanks a lot! 😃

I will keep that in my mind next time. Because this was a small fix, so I just add push it to main directly.

rohit9625 commented 2 months ago

However, this file will get overwritten the next time translations are pulled from TranslateWiki.

So, I need to make a change on Gerrit also. Right?