search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.02k stars 1.23k forks source link

Caption lost after accepting "Is this a picture of..." #5842

Open nicolas-raoul opened 3 weeks ago

nicolas-raoul commented 3 weeks ago

Steps:

  1. Prepare two images, the second with coordinates near a Wikidata item (you can download them from Commons to test)
  2. Enter a caption. Imagine the user is taking the time to write a great/accurate/descriptive very long caption.
  3. Go to the second image. The dialog "Is this a picture of..." appears, click Yes
  4. Problem: You loose everything you had typed.

https://github.com/user-attachments/assets/15c92af5-0ed7-4b0b-9305-aea3b9f1ae5a

Ideally the app would read the coordinates of all pictures of the multi-upload, find the first one whose coordinates are near a Wikidata item (something smarter can be devised in the future such as barycenter or clustering but let's keep this task simple for now), ask "Are these pictures of...", and only then let the user enter captions.

QuantumPineapple68 commented 3 weeks ago

actually, i have ran the application i cannot see any error as such. is it this problem still there or is it closed

nicolas-raoul commented 3 weeks ago

@QuantumPineapple68 Still happening to me. Are you using the GitHub main branch? Can you post a screencast? Thanks!

QuantumPineapple68 commented 1 week ago

I checked it so many times and the issue seems to be solved. I am using the main branch itself. Can you please check once again from your end, and let me know ?? Thanks ![]()[]()[]()[]()[]()https://github.com/user-attachments/assets/a17c37c2-a116-4414-ab44-dc45f4060ab5

nicolas-raoul commented 1 week ago

@QuantumPineapple68 In your screencast, I see you are not getting the dialog "Is this a picture of...", right?

The bug only happens if you get that dialog.

To get that dialog, the second picture must have coordinates near a Wikidata item. Please download and use that picture to use as the second picture: https://upload.wikimedia.org/wikipedia/commons/b/bb/%E4%BA%AC%E7%8E%8B%E3%83%AA%E3%83%88%E3%83%8A%E3%83%BC%E3%83%89%E6%B0%B8%E7%A6%8F%E7%94%BA.jpg (when a popup dialog tells you Image is already on Commons just press Upload).