search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.03k stars 1.23k forks source link

`Dexter` library's repo for handling permissions is archived #5888

Open parneet-guraya opened 1 month ago

parneet-guraya commented 1 month ago

We're using Dexter for handling permissions in few places. But it has been archived a long ago. Also, I have seen in other places we're using android API's directly. So, maybe we can remove this and if there's a special case that this library was handling then we need to find another solution.

Would you like to work on this? Yes!

nicolas-raoul commented 1 month ago

If removing Dexter does not add complexity, I am all for it. 🙂 Please remember to test well, resetting the app's settings and showing maps/etc from various activities. Thanks!

parneet-guraya commented 1 month ago

Got it! 👍

rohit9625 commented 1 month ago

Will you replace it with another library or create a permission-handling utility class from scratch?

parneet-guraya commented 1 month ago

Most likely use the API directly :)

rohit9625 commented 1 month ago

I would suggest creating a class instead from scratch.

psh commented 3 weeks ago

As you move toward Compose UI, it might be worth bearing https://google.github.io/accompanist/permissions/ in mind.