search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.03k stars 1.24k forks source link

[Bug]: Edit location button shown even when image does not have location #5908

Open sivaraam opened 3 weeks ago

sivaraam commented 3 weeks ago

Summary

When trying to upload an image, there seems to be some kind of uncertainity with which the app identifies the presence of location in the image. In an instance, the "Edit location" button was shown for an image that did not have location in the EXIF. The "No location found" prompt is properly shown, though. This is in a device running Android 12.

Note that I'm not able to reliably reproduce this for all images. I do see the "Add location" button for other images. For example:

Steps to reproduce

  1. Open the app
  2. Try to upload the image found here
  3. Notice the "Edit location" button shown
  4. Fill in the "caption" and "description"
  5. Click "Next" and notice the "No location found" prompt shown

Expected behaviour

The app identifies that the image does not have location and shows the "Add location" button.

Actual behaviour

The app shows the "Edit location" button incorrectly for an image that does not have a location.

Device name

OnePlus Nord

Android version

Android 12

Commons app version

5.1.0~522f1fe19

Device logs

No response

Screen-shots

Screenshot_2024-10-08-20-09-51-36_d5db3f3edc380047609fe9c266f7c566_1

Would you like to work on the issue?

None

nicolas-raoul commented 3 days ago

"This is an image for which I see the "Edit location" button incorrectly"

Reproducible every time?