search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
998 stars 1.18k forks source link

Reducing Codacy issues #778

Open psh opened 7 years ago

psh commented 7 years ago

How does everyone feel about the number of Codacy issues - is this something that is used in a relative sense (to judge a given feature based PR as to whether it generally improves the codebase) or is it a measure in an absolute sense (should look to reduce the count to get the code into a better place).

I guess what I am asking is whether you'd like a PR that reduces the Codacy issue count from 845 to around 720 with no actual functionality difference, or make that the basis for a PR with some feature work.

On my software team folks would call it "code beautification" and be quite dismissive unless there was some additional business value! ;)

whym commented 7 years ago

I just incidentally submitted #779 (mostly about whitespace issues) without seeing this discussion. Personally I wouldn't mind receiving such PRs unless we are flooded by them (like 10 PRs for 10 lines of changes in total).

That said, people might have different opinions on some of the checks - notably a (often slight) violation of maximum length of line (#465). On the other hand, there are things like wrong indentation levels (such as missing one space) that are considered almost universally wrong - these fixes might be more welcomed.

misaochan commented 7 years ago

I'm good with such a PR (like @whym said, with reasonable consolidation though).

On a tangential note, I wonder if we can/should change the settings for line length warnings?