search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.02k stars 1.23k forks source link

Change the app's icon #868

Closed sivaraam closed 4 years ago

sivaraam commented 7 years ago

It seems the app's icon needs some update. It doesn't look so nice on some backgrounds.

commons logo

Though the logo seems to be clear in the above screen shot it's not when the brightness is low. It's very hard to identify it.

How about giving it a circular (Android O's coming) white background to it.

thetimaw commented 7 years ago

i gave it a white border

psh commented 7 years ago

If we're going to play around with the icon, I'd suggest digging into Google's style guide - https://material.io/guidelines/style/icons.html

The other small change would be to create 'adaptive icons' (see https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive.html) so that Oreo users see icons more suited to the platform.

thedeadline commented 7 years ago

Hi, I'd like to create an adaptive icon for the app but I can't find the raw file for the icon... is the original vector file (illustrator, sketch, etc.) available in the repo?

Thanks, I'm new to open source contribution (doing it for Hacktoberfest) :).

nicolas-raoul commented 7 years ago

The SVG is on Wikimedia Commons 🙂

On Oct 8, 2017 07:54, "Isabelle Giuong" notifications@github.com wrote:

Hi, I'd like to create an adaptive icon for the app but I can't find the raw file for the icon... is the original vector file (illustrator, sketch, etc.) available in the repo?

Thanks, I'm new to open source contribution (doing it for Hacktoberfest) :).

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/commons-app/apps-android-commons/issues/868#issuecomment-334971086, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGFBvoOAjxt8vK_uxFWBj3VH_M4QvUcks5sqAEUgaJpZM4POyJp .

psh commented 7 years ago

@nicolas-raoul - Do you think it would be a good idea to drop a copy into the 'design' folder of this project, just for reference?

thedeadline commented 7 years ago

@nicolas-raoul can you be more specific? I only see the ic_launcher psd source file but it doesn't look like the current app icon. I agree with @psh I thought it would be in 'design' and looked there first.

nicolas-raoul commented 7 years ago

Here is the SVG: https://commons.wikimedia.org/wiki/File:Commons-logo.svg Yes, feel free to add it inside the project, good idea!

neslihanturan commented 6 years ago

Actually a related PR already merged, but our logo still looks same, I couldn't understand the reason. But if we are okay with current look of the icon, I will close this discussion. Personally, I am okay.

nicolas-raoul commented 6 years ago

The merge was only so that it behaves differently on Android O, apparently.

I agree that the icon is sometimes not very visible. If anyone has a good design that make the Commons icon more visible, feel free to propose it.

neslihanturan commented 6 years ago

Actually @tim-weaver made white borders for our icon at #875 but since the PR didn't merged for long time, and I think it doesn't look very beautiful with white borders, closed the PR. We can always re-open and merge it if you like white borders. But I think we are still welcome design ideas for Commons icon.

sivaraam commented 6 years ago

We can always re-open and merge it if you like white borders.

I think it doesn't improve things much.

But I think we are still welcome design ideas for Commons icon.

How about using one version of the adaptive icons (I like the square one with the rounded corners) for other android versions? I guess it would solve the issue.

whym commented 6 years ago

It might be useful to ask Wikimedia Foundation Legal team about what kind of modifications are allowed to the original logo which is a trademark of theirs. (I believe this app's logo is under a trademark agreement with them, right? Unless perhaps we choose an entirely new one.)

I found https://wikimediafoundation.org/wiki/Visual_identity_guidelines but it only talks bout the Wikipedia logo. (They are fairly restrictive about it, by the way)

utsha1510 commented 6 years ago

if in case we can choose an entirely new one, I can design one.

nicolas-raoul commented 6 years ago

@utsha1510 It should be based on the Commons icon (SVG above).

Anyone feel free to propose an icon (or prototype of icon), but be aware that the WMF might refuse it, so please don't be upset if that happens ^_^ Cheers!

sdabhi23 commented 6 years ago

logo_flat logo_elevated

These are the 2 designs I could come up with, by doing minimum modifications in the original logo.

nicolas-raoul commented 6 years ago

I like the first one. The concept of adding a white rounded rectangle background is also used by the Wikipedia and Wikivoyage apps, which is a plus. I would say that I support switching to that icon.

misaochan commented 6 years ago

The first icon looks good to me too. :)

@nicolas-raoul I guess we will have to ask WMF Legal first before we can use it?

nicolas-raoul commented 6 years ago

@misaochan Good idea indeed!

sdabhi23 commented 6 years ago

The merge was only so that it behaves differently on Android O, apparently.

The latest update broke it, and now it doesn't even work on Android O.

debpedrano commented 5 years ago

Hello! how was everyone? can I submit my design for this project?

sdabhi23 commented 5 years ago

@debpedrano you will have to post the design on this issue. If it is approved then they will let you know about the assets they require.

debpedrano commented 5 years ago

@sdabhi23 Design # 1

image

Design # 2 image

Design # 3 image

misaochan commented 5 years ago

@debpedrano We really appreciate the effort, but it is extremely unlikely that we will change the base logo, as it is based on the Wikimedia Commons logo and is a big part of our identity. However, we are open to changes to the app's icon, as long as the base logo remains the same. :) For instance, you can modify shading or the background color, etc.

sdabhi23 commented 5 years ago

@misaochan any updates on the designs I suggested?

misaochan commented 5 years ago

@sdabhi23 I apologize that I have not had the time to talk to WMF Legal about this due to grant deadlines. If they approve, I am good with switching to the first icon (that @nicolas-raoul liked as well).

Could anyone volunteer to send WMF Legal an email about this?

debpedrano commented 5 years ago

@misaochan so you mean we will just stick on the base logo and put some modification to add some enhancement? I will do that if that's what you meant.

sivaraam commented 5 years ago

Could anyone volunteer to send WMF Legal an email about this?

Hi @misaochan, just for the clarification: can anyone not much involved in the project also ask WMF legal about this? If that's the case I might help you with this.

misaochan commented 5 years ago

@sivaraam Sure, absolutely, please just link them to https://github.com/commons-app/apps-android-commons/issues/868#issuecomment-414520069 , thanks :)

@debpedrano Yes, that's what I meant. :) However, from looking back at the thread, it seems @sdabhi23 has submitted designs for this some time ago, we are just pending an answer from WMF Legal before we can incorporate them. Are you looking for design tasks to work on?

@neslihanturan any ideas if we have any other design tasks open at the moment?

sivaraam commented 5 years ago

@sivaraam Sure, absolutely, please just link them to #868 (comment) , thanks :)

No problem :-) Just for the confirmation is trademarks@wikimedia.org the email address to which I would have to send an email or is it legal@wikimedia.org ?

misaochan commented 5 years ago

I think legal@wikimedia.org should work, if they need to forward it to trademarks they could do so?

sivaraam commented 5 years ago

@misaochan I've sent the mail. You should have received a copy. Let me know, if not. Let's wait for the response.

misaochan commented 5 years ago

Thanks @sivaraam !

debpedrano commented 5 years ago

@misaochan yes, I don't have work for now and its kinda bored to stay at home and do nothing that's why I am making issue (logo designs) to entertain myself. If you have any project that needs a logo, you can count on me, everything is for free.

misaochan commented 5 years ago

@debpedrano Ah, cool. Are you open to doing any other types of design, or do you only do logos?

debpedrano commented 5 years ago

@misaochan I am still a beginner, I only do logo(s). hoping soon I can do animation and ui design.

nicolas-raoul commented 5 years ago

@debpedrano It is not logos, but you might be interested in this project: https://github.com/nicolas-raoul/Icons-for-Wikidata :-)

sivaraam commented 5 years ago

Let's wait for the response.

I'm glad to inform people here that WMF legal is fine with icon that has been suggested (the first one)! They're also fine with making that icon adaptive as long as only the background shape changes.

misaochan commented 5 years ago

Yay! @sdabhi23 Please feel free to submit your PR with the first icon. :)

sdabhi23 commented 5 years ago

@misaochan as there are new year celebrations going on here (in India), will it be ok if I do it after a couple of days?

misaochan commented 5 years ago

Sure, absolutely. Happy Diwali? :)

sdabhi23 commented 5 years ago

Yeah. Thanks :D

neslihanturan commented 5 years ago

If we have some volunteer designers, I think nearby descriptor images can be a good point to start. image

I like question mark but, when it comes to other icons, I think they don't match with our app style. Something similar to designs in achivements activity would be nice: image

And using our base colors and having a consistent feeling between these icons could be good.

Note: If you start to work on this task, please share step by step improvements.

sdabhi23 commented 5 years ago

Hey @misaochan @neslihanturan is there a svg available for the logo for the beta version? Or even a png would work!

sdabhi23 commented 5 years ago

I would like to suggest using this logo for the beta version.

beta

misaochan commented 5 years ago

Ah, we actually have a logo for the beta version! It is just the same logo as the Commons logo, but with "beta" added. Could you please take a look in the /res/ folder for it? I personally like your new logo (very ingenious, by the way ;)), but that would require us to ask permission from Legal all over again. Whereas if you use the existing beta logo and just modify the background similar to what you did for the Commons logo, we should be fine.

nicolas-raoul commented 5 years ago

The new icon is very small compared to before: screenshot_20181217-200237 Would someone mind checking why? It should be as big as the Alarm Klock (also open source so feel free to have a look at their configuration) icon.

sdabhi23 commented 5 years ago

@nicolas-raoul can you share the configuration of you device (like screen size, android version, screen resolution, etc)? I am not able to reproduce it.

Also keep in mind the fact that alarm klock is a legacy project with ant builds which is no longer being maintained, so it might behave oddly on some devices. The icons for our app were generated automatically by Android Studio from the background and foreground layers.

You can refer the image attached below for comparison with system app icons on Android 8.1, with adaptive icons:

comparison image

nicolas-raoul commented 5 years ago

LineageOS 7.1.2 on Nexus 5 (1080×1920 pixels) More icons for comaprison: screenshot_20181217-233508

domdomegg commented 5 years ago

Got same issue as @nicolas-raoul

LineageOS 7.1.2 on Samsung Galaxy S6 (2560x1440 pixels)

Evie launcher

Screenshot screenshot_20181219-003226

Also personally I prefer circular icons, which the app previously used. Is there any way to set that as the default icon style for devices that don't support adaptive icons (i.e. those with API level <= 25)? However probably up for debate as I think Wikipedia app does use rounded square.

EDIT - having a read of https://medium.com/google-design/designing-adaptive-icons-515af294c783 suggests that it might actually be the right size (at least in my case) as the square should be ~15% narrower than circles.

nicolas-raoul commented 5 years ago

The icon size difference is especially visible in the Share dialog (please disregard the peppers), both icons are rounded squares but the "LINE" icon is much bigger:

screenshot_20181220-142711