Closed misaochan closed 4 years ago
Excuse my ignorance. Where are we actually thinking of placing this icon? 😅 Would it appear after tapping the FAB that appears after tapping on a Nearby place? Or would it appear somewhere else?
I'm thinking that after the user has uploaded a photo through Nearby and the photo upload succeeds, it would appear next to the picture in Contributions, maybe overlapping a bit with it on the lower right corner?
Apparently "we" are smarter :-) With my Android's locale set to Japanese, I tapped a pin in Japan, it had a Wikipedia icon. I tapped it, and it directed me to the Japanese Wikipedia article. By the way, that item also has an English Wikipedia article.
Oh nice!! :D
I'm thinking that after the user has uploaded a photo through Nearby and the photo upload succeeds, it would appear next to the picture in Contributions, maybe overlapping a bit with it on the lower right corner?
Thanks for the clarification. That sounds like an appropriate place for it.
BTW, I think we really have to update the issue title now after all the discussion. The title was what actually confused me 😄
@sivaraam I tried. It was surprisingly hard to capture all that in one sentence. 😄
@sivaraam I tried.
It's good. Just a minor suggestion, I think it would be nice if we could convey that the icon would be per image more clearly.
Here's an alternative suggestion:
In Contributions list, add an icon for images uploaded via Nearby that allows users to use that image in associated Wikipedia article(s)
I'll come to that article(s)
part in an upcoming comment.
It was surprisingly hard to capture all that in one sentence. 😄
Oh, don't be surprised. It's true. 😃
"I didn't have time to write a short letter, so I wrote a long one instead." - Mark Twain [ref]
Off topic, you're the second person that I see stating this today. The first one being @b0rk. These coincidences are intriguing. 🤔
Is there any reason not to show a list of all Wikipedia articles (I mean all language versions of the article) associated with a Nearby uploaded image and let the user decide which version of the article the image should be added to?
I realise that a Wikidata item could contain links to a lot of language versions making it harder for the user to find the ones he wants. We could fix that in a couple of possible ways (or mix of both):
If we do both, then the languages we get from the second one should have precedence over the first.
Just a suggestion that popped in mind. 🙂 Let me know if there are other issues that I've missed.
@misaochan Do we need to put this feature to be put specifically in the contribution list or can we have it in the Media details screen where all other media related actions are present.
The issue with adding it in the list is that I will have to make an API call for every single image which was uploaded via nearby in the list to check if the corresponding Wikipedia article contains an image or not. It would add undue complexity in the list.
If we load asynchronously little by little, and cache the information, I guess it will not slow down the app much? If we check for many languages that might be more severe, though.
Downloading the wikicode of the article and checking for "[[File:" or other language equivalents might be enough. We should get the non-transcluded wikicode, because for instance https://en.wikipedia.org/wiki/Souvign%C3%A9-sur-M%C3%AAme has 5 images but all transcluded.
Downloading the wikicode of the article and checking for "[[File:" or other language equivalents might be enough.
I was of the impression that we were going to use the /page/media
API to fetch the images used in the article. Even the description of this issue says so. Did I miss anything? 🤔
@maskaravivek I understand, but I strongly feel that if the user must enter media details view in order to see this, the feature will be used far less frequently than if it was on the main contributions list. Unlike the other actions, this option will probably not be present for the majority of a user's images, so it would be burdensome for them to go through every one of their pics individually to see which ones are applicable (which means they will probably just not do it). As Nicolas says, loading asynchronously should help with performance? If anyone else feels differently, please do chime in. :)
Is there any reason not to show a list of all Wikipedia articles (I mean all language versions of the article) associated with a Nearby uploaded image and let the user decide which version of the article the image should be added to?
IMO this would add undue complexity, especially as this is our first time rolling out the feature. I think it may be best to simply use the phone's language as the default for the time being, and then add this enhancement later if desired.
I was of the impression that we were going to use the /page/media API to fetch the images used in the article. Even the description of this issue says so.
Yes, I am of that impression too. ;)
Loading the contributions page by page sounds good. I have started a WIP PR(#3566) that loads contributions 10 at a time and loads more on scrolling down. Having it in place would make this task easier. @ashishkumar468 has volunteered to help me with this PR(ie. #3566).
@sivaraam Oops I forgot that, sorry 😓
I am going to use the following API to check if the Wikipedia page contains media or not.
https://en.wikipedia.org/api/rest_v1/page/media-list/A._P._J._Abdul_Kalam
@neslihanturan Can you export the 3rd icon separately and share it here. In your comment above all icons are in the same image.
Prior to entering the editor, we should have a popup with basic instructions of what to do, and the wikicode for that image displayed for easy copying
@misaochan Can you help me with text for the instructions.
Also, I was planning to directly copy the wikicode to the clipboard and show this on the instructions dialog (along with the instructions).
"Wikicode has been copied to the clipboard"
I think it's good to check with the legal team about the modified version of the Wikipedia logo. It shouldn't be a problem if we haven't changed it. But we have added a plus icon and the Wikipedia Visual identity guidelines mentions:
Do not... ^
...alter the Wikipedia or related project identities nor any of their elements.
So, it would be good to check with the legal team about this.
For the instructions, @nicolas-raoul would you have any suggestions on what we should tell them? I actually am not that familiar with wikipedia editing, haha.
Good idea @sivaraam , I'll contact the legal team just to be sure.
I am going to use the following API to check if the Wikipedia page contains media or not.
en.wikipedia.org/api/rest_v1/page/media-list/A._P._J._Abdul_Kalam
On reading this initially and searching, I realised that the /page/media
API is missing from the API page. I've wondered what happened to that API. I happened to come across an answer for it now. Links to related phba tickers for reference:
As discussed in #252, we might want to allow the user to edit the associated Wikipedia article to add the image, after the user has successfully uploaded a pic for a Wikidata item. This would complete the "chain" of seamless workflow after the other improvements at #252 are completed during the renewal - users can browse the places that need photos, select one and move to the location, directly upload the photo after taking it (with suggested titles and categories based on the Wikidata item), and THEN add it to the Wikipedia article that is associated with that item.
We could see if the Wikipedia app allows us to do that, or otherwise link to the web view. Otherwise, we could also implement the functionality in our own app if other options don't suit (last resort).
Considerations:
Edit 30 Jan 2020:
Scope of task: