search

commons-app / commons-app.github.io

Website for the Android Commons app
https://commons-app.github.io
Apache License 2.0
17 stars 27 forks source link

Migrating to bootstrap? #20

Closed domdomegg closed 7 years ago

domdomegg commented 7 years ago

As the title says, do you think it's worth migrating to bootstrap - should be pretty easy with what's on the site currently and could be easier to maintain in the future, especially if thinking of transferring to a web framework. Currently seems to be loads of CSS code that whilst including bootstrap would remove most of it and end up looking identical, or very similar at least.

tobias47n9e commented 7 years ago

We could look into that if we expand the page at some point. At the moment I think we can just maintain it until we know what to do next.

domdomegg commented 7 years ago

Gonna close this issue, as not really an 'issue', made this quickly just to kinda see what it's like: https://github.com/domdomegg/commons-app.github.io/tree/bootstrap

tobias47n9e commented 7 years ago

I will gladly merge it if it makes further development of the page easier. Is there anything else that you think needs improvement?

domdomegg commented 7 years ago

Reopening as potentially going to submit a PR to migrate to boostrap.

domdomegg commented 7 years ago

See PR #21