commons-app / commons-app.github.io

Website for the Android Commons app
https://commons-app.github.io
Apache License 2.0
17 stars 27 forks source link

Updated - Navigation Bar Styling, animation, highlights active section and page smooth scrolling etc. #32

Closed 0xSG closed 5 years ago

0xSG commented 6 years ago

Features added:

0xSG commented 6 years ago

Hi. This is Surya here. The code which i added is tested and it's live at here.

sivaraam commented 5 years ago

Hi @0xpulsar,

Just saw the live website. The changes seems to be nice. But the favicon doesn't seem to have come into effect. I still see no icon in the tab for the website. Any idea why?

0xSG commented 5 years ago

Let me check.

0xSG commented 5 years ago

@sivaraam Can you fix it? My exams are going on.

sivaraam commented 5 years ago

Can you fix it?

Just to be sure, fix what? Fix the missing website icon?

sivaraam commented 5 years ago

Anyways, I guess I've found the issue. I made a PR to your repo with the fix. https://github.com/0xpulsar/commons-app.github.io/pull/1

You could see it live at https://sivaraam.github.io/commons-app.github.io/

0xSG commented 5 years ago

@sivaraam, I have merged and solved merge conflict. can you review it?.

sivaraam commented 5 years ago

@0xpulsar On a cursory view, I guess the merge isn't proper. You seem to be including styles from both bootstrap 4.0.0-alpha and 4.1.1 as a consequence of which the page looks odd at some places. Could you re-merge it properly?

sivaraam commented 5 years ago

Closing this as #34 has been merged. Also, the website icon has been added in #38.

Hope to see you again @0xpulsar with another PR :)