Closed 0xSG closed 5 years ago
Hi. This is Surya here. The code which i added is tested and it's live at here.
Hi @0xpulsar,
Just saw the live website. The changes seems to be nice. But the favicon doesn't seem to have come into effect. I still see no icon in the tab for the website. Any idea why?
Let me check.
@sivaraam Can you fix it? My exams are going on.
Can you fix it?
Just to be sure, fix what? Fix the missing website icon?
Anyways, I guess I've found the issue. I made a PR to your repo with the fix. https://github.com/0xpulsar/commons-app.github.io/pull/1
You could see it live at https://sivaraam.github.io/commons-app.github.io/
@sivaraam, I have merged and solved merge conflict. can you review it?.
@0xpulsar On a cursory view, I guess the merge isn't proper. You seem to be including styles from both bootstrap 4.0.0-alpha and 4.1.1 as a consequence of which the page looks odd at some places. Could you re-merge it properly?
Closing this as #34 has been merged. Also, the website icon has been added in #38.
Hope to see you again @0xpulsar with another PR :)
Features added: