Deprecate searcher.py in favor of the Go client?

commonsearch / cosr-back

Backend of Common Search. Analyses webpages and sends them to the index.

https://about.commonsearch.org

Apache License 2.0

123 stars 24 forks source link

Deprecate searcher.py in favor of the Go client? #2

Open sylvinus opened 8 years ago

sylvinus commented 8 years ago

Still not sure if we should entirely remove searcher.py

It's only used in tests. If we remove it we'd have to make at least the cosr-back tests depend on the cosr-front code.

Pros:

Less code duplication/maintenance
Less risk of subtle diffs that would make debugging hard.

Cons:

More complex setup
Unnatural dependency between both projects
One more language to understand for people willing to contribute

sylvinus commented 8 years ago

Actually I find it somewhat practical and maybe even beneficial to iterate on the Python code, break tests, tweak things, and then freeze the code in the Go client. It is a bit more work, but not that bad.

chris-heney commented 8 years ago

I agree with interactive dev/design principles.