commonsearch / cosr-back

Backend of Common Search. Analyses webpages and sends them to the index.
https://about.commonsearch.org
Apache License 2.0
122 stars 24 forks source link

Add Commonsearch PageRank Signal #70

Closed HenriqueLimas closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.06%) to 86.039% when pulling 36532beb11fe81b4b34ce7a0162f69f702728e48 on HenriqueLimas:ranking_pagerank into aa805730bd1bcae8bf15b889a534bb54f8d89dd9 on commonsearch:master.

sylvinus commented 7 years ago

The patch looks great, congrats @HenriqueLimas!

I've added a couple of comments. Also, there are 2 linting errors before we can merge: https://travis-ci.org/commonsearch/cosr-back/builds/167804916

Thanks!!!

HenriqueLimas commented 7 years ago

@sylvinus, the lint errors is about the Header of the request that I needed to add..Do you think it's correct adding the Header User-Agent?

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.06%) to 86.039% when pulling e2cfa179917a92baaaf762fc8ec1e1aabba0dc26 on HenriqueLimas:ranking_pagerank into aa805730bd1bcae8bf15b889a534bb54f8d89dd9 on commonsearch:master.

sylvinus commented 7 years ago

Great, thanks a lot @HenriqueLimas !