commonsearch / cosr-front

Frontend of Common Search. Go server for fetching and rendering results + HTML5 UI to browse them.
https://uidemo.commonsearch.org
Apache License 2.0
60 stars 13 forks source link

Broken magnifying glass on search box #26

Open meshy opened 8 years ago

meshy commented 8 years ago

Browser: Firefox 45.0 OS: Manjaro (Arch) Linux

screenshot from 2016-03-14 11-22-31

This unicode char is supposed to be a left-pointing magnifying glass (U+1F50D), but the unicode symbols are not globally accepted. Perhaps this would make more sense as an SVG?

sylvinus commented 8 years ago

Thanks for reporting! Are there easy solutions to detect SVG support and have a proper fallback to image? We could do this with the logo too by the way ;)

meshy commented 8 years ago

Thanks for reporting!

My pleasure -- this looks like a very interesting project :)

Are there easy solutions to detect SVG support and have a proper fallback to image?

It looks as though modernizr supports this. I don't know the details of how the detection works, sorry.

I don't know if it's worth it though -- as far as I as aware the vast majority of browsers now support SVG (the exception being IE8, which MS no longer support).

We could do this with the logo too by the way ;)

Sounds like a good idea to me :)

sylvinus commented 8 years ago

This looks like the most promising way to do it: https://css-tricks.com/a-complete-guide-to-svg-fallbacks/#fallback-inline-svg-text

meshy commented 8 years ago

That looks like a really good resource. I've personally used the inline svg it mentions there recently, but I can't remember what broswer I was targetting.

Is there a formal definition of the browsers that commonsearch intends to support? That would probably help us to select the correct solution.

sylvinus commented 8 years ago

@meshy you're very right. I'm going to write some more docs to be a little more explicit about the requirements! There are some here: https://about.commonsearch.org/developer/frontend but they should be expanded.