Closed mewmew closed 8 years ago
This pull request was sent out prematurely. It turns out that aliases are ignored by make
, or rather only used by interactive terminal environments. In either case, the described solution does not fix the initial problem.
Thanks for the PR! I'm sure there is a way to make it work for all users.
I agree that there should be a bit on making sure the docker daemon is started, ideally with links to the right places in the docker documentation for each platform, to avoid duplicating too much on our end!
I agree that there should be a bit on making sure the docker daemon is started, ideally with links to the right places in the docker documentation for each platform, to avoid duplicating too much on our end!
I agree. Avoiding duplication is good, while making sure most users never even have to click the links, by including the minimal set of commands to get them up and running.
The official docker documentation is good, but does not mention any alternative solutions to mitigate the security implications of adding your user the docker
group as far as I'm aware. That's why I added the alias solution (which turned out not to be working in the end).
@sylvinus, thanks for taking the lead to create a really wonderful project! It is a very important issue you are trying to solve, as I'm sure you are already aware. And it looks like others are starting to see the dangers of proprietary ranking algorithms as well https://aeon.co/essays/how-the-internet-flips-elections-and-alters-our-thoughts
Best of luck in your future efforts! :) I'll try to follow the development of Common Search and hopefully contribute in one way or another.
Cheers /u
Thanks @mewmew! Now that you have a working local install I definitely hope you can contribute more :)
…er. Fixes #27.