search

commonsearch / cosr-front

Frontend of Common Search. Go server for fetching and rendering results + HTML5 UI to browse them.
https://uidemo.commonsearch.org
Apache License 2.0
61 stars 13 forks source link

server/bangs: Added archlinux, imdb, python and stackoverflow bangs #35

Closed gkbrk closed 8 years ago

sylvinus commented 8 years ago

Hi @gkbrk! Thanks for the patch :)

I think we need to have a broader discussion around our policy for including and naming bang codes.

As an example, adding !imdb seems like a no-brainer, but on what grounds should we give !aw to wiki.archilinux.org?

It would be interesting to research duckduckgo's policies and other organizations that had to face a similar issue!

gkbrk commented 8 years ago

I actually got !aw from DuckDuckGo, but I agree that single or two-lettered bangs should be allocated carefully. I can rename it !archwiki or keep it temporarily with a comment to discuss it later.

sylvinus commented 8 years ago

Ok. Another question raised by !python: should we point to python 3 or python 2? I don't want to start a debate on python 3 adoption and it's admittedly a small detail, but I'm interested in the resolution process itself.

gkbrk commented 8 years ago

Hmm, I think !python and !py for Python 3 and !python2 and !py2 for Python 2 should cover most cases. Adding !py3 and !python3 for the sake of completeness might be a good idea too.

sylvinus commented 8 years ago

I'm still thinking about this ; should we bootstrap a larger database of bangcodes semi-automatically or wait for people to send pull requests for their favorite ones?

hjacobs commented 8 years ago

@sylvinus adding bangs "on-demand" (waiting for pull requests) is fine I think.

sylvinus commented 8 years ago

ok! @gkbrk can you update the PR with everything that was said here?

gkbrk commented 8 years ago

I'll update the PR today after school. On Apr 14, 2016 6:47 AM, "Sylvain Zimmer" notifications@github.com wrote:

ok! @gkbrk https://github.com/gkbrk can you update the PR with everything that was said here?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/commonsearch/cosr-front/pull/35#issuecomment-209745398

gkbrk commented 8 years ago

Removed !aw for Arch Wiki, added !pypi for PyPi.

sylvinus commented 8 years ago

Great, thanks!