commonsearch / cosr-front

Frontend of Common Search. Go server for fetching and rendering results + HTML5 UI to browse them.
https://uidemo.commonsearch.org
Apache License 2.0
61 stars 13 forks source link

Limit query length to be 10 words at most #42

Closed chaconnewu closed 8 years ago

chaconnewu commented 8 years ago

issue link: https://github.com/commonsearch/cosr-front/issues/17

Screenshot: 10 words

sylvinus commented 8 years ago

Wow that's great, thanks @chaconnewu!

My only feedback is that it would be nice to have this limit configurable, by adding an entry in config.go. Seems doable?

chaconnewu commented 8 years ago

@sylvinus great suggestion! Just pushed a commit for it.

chaconnewu commented 8 years ago

Just renamed the variable and fixed the comment lint error

sylvinus commented 8 years ago

Awesome! Congrats, probably the cleanest patch we've had so far ;)

chaconnewu commented 8 years ago

Thanks @sylvinus ! It is a lot of pleasure to work on this project 😄