search

commonsmachinery / blockhash

blockhash.io
MIT License
86 stars 28 forks source link

'v' in 0.3 tag name #24

Closed ilovezfs closed 6 years ago

ilovezfs commented 6 years ago

Did you intend for the 0.3 tag to have a leading 'v'? That seems to be a break from precedent. https://github.com/commonsmachinery/blockhash/tags

artfwo commented 6 years ago

That wasn't intentional, it's what GitHub recommends when drafting a release :) Does that break anything besides tradition?

ilovezfs commented 6 years ago

I only noticed because my script takes the url and replaces the old version with the new version, which failed. It doesn't actually break anything, but I don't want to ship the upgrade in Homebrew if it's going to end up getting retagged subsequently.

artfwo commented 6 years ago

@ilovezfs I see, sorry about that. Since you've already updated the script in the linked homebrew PR, I suggest we stick to prefixing this and future releases with v, what do you think?

ilovezfs commented 6 years ago

No problem.

I suggest we stick to prefixing this and future releases with v, what do you think?

makes sense to me!

ilovezfs commented 6 years ago

I've now shipped 0.3 in Homebrew.

artfwo commented 6 years ago

Great, thanks!

ilovezfs commented 6 years ago

You're welcome! :)