commonsmachinery / blockhash

blockhash.io
MIT License
86 stars 28 forks source link

feat: add ci-cd workflow for tests #36

Closed eredotpkfr closed 8 months ago

eredotpkfr commented 8 months ago

I added ci-cd stages for tests, can you check out please? @jonasob @artfwo

eredotpkfr commented 8 months ago

Can you checkout my pr? I have been added ci-cd workflow for tests @wjt @jonasob @pombredanne @artfwo

artfwo commented 8 months ago

I have a couple of questions here:

What is the purpose of this change?

Why is extra chmod +x test.sh in the workflow file? This file should already be executable after checkout.

eredotpkfr commented 8 months ago

I have a couple of questions here:

What is the purpose of this change?

Why is extra chmod +x test.sh in the workflow file? This file should already be executable after checkout.

In my previous pr If you remember. I fixed the hash value in tests, there was no ci-cd stages right there, I think ci-cd stages important to development. For example some changes on hashing algorithm may impacts to tests so we can understand some places are broken. If you think unnecessary for this project we can close the pr

You are right about chmod +x test.sh, may it is unnecessary line but I wrote to make them more understandable, I can remove it

Thanks for comments @artfwo

artfwo commented 8 months ago

Thanks for clarifying, @eredotpkfr . I am fine with merging this, given the following:

eredotpkfr commented 8 months ago

I changed the things you said, thanks for your interest @artfwo