Add aarch64 binaries to releases?

commontk / AppLauncher

Simple and small program allowing to set the environment of any executable.

http://www.commontk.org

Apache License 2.0

31 stars 32 forks source link

Add aarch64 binaries to releases? #120

Open adamrankin opened 3 years ago

adamrankin commented 3 years ago

Hello,

Is it possible to include a binary build for aarch64 into the releases?

jcfr commented 3 years ago

That should indeed be possible. We would be happy to review contributions.

Here are the steps:

Create a static build of Qt and document how to create and update such a build. For each platform we currently support, we download a static build of Qt. See details at https://github.com/jcfr/qt-static-build
Update continuous integration to build for aarch64. May be we can re-use some of the work done to support building cmake python wheel for aarch64 (see https://github.com/scikit-build/cmake-python-distributions/blob/master/.travis.yml)

adamrankin commented 3 years ago

The static build of Qt is 4.8.6. Did you want to continue using that version?

jcfr commented 3 years ago

The static build of Qt is 4.8.6. Did you want to continue using that version?

If you already have a Qt build for aarch64 and it 4.8.6, that is a good starting point.

What do you think of creating a release called applauncher-4.8.6-aarch64 in https://github.com/jcfr/qt-static-build/releases and update the README ?

If that sounds good, I will create the release and grant access so that we you can update the release description, upload file and describe how it was generated.

adamrankin commented 3 years ago

I'm still trying to wrap my head around all the automated build system stuff. Would this not be the same as the linux docker image, just with a different base image?

Edit: what I mean by automated build system understanding: can we add another entry to the circleCI system to also build aarch64, just have a different Qt-static docker image?

adamrankin commented 3 years ago

Ok, @jcfr I've made a docker image with Qt 5.12.10 built. Should I zip up the Qt build folder inside and upload it to a release?

Edit (links): Docker makefile and dockerfile here: https://github.com/adamrankin/qt-static-build

Docker image here: https://hub.docker.com/layers/adamrankin/qt-static/5.12.10-ubuntu-20.04/images/sha256-adf327868df7a2e009d507376ce16333b3c8430a177b5b32b75efcf6c975ac94?context=explore

jcfr commented 3 years ago

made a docker image with Qt 5.12.10 built

This is great.

I suggest the following next steps:

check that you can run the test from the build tree of the AppLauncher
check that the binary created can be run on the target platform (you can do make package to first create an archive)

adamrankin commented 3 years ago

Good call. libpng linking issues! Will update when I have a working package.

adamrankin commented 3 years ago

Should I redo my docker image to be based on a dockcross image? With my current docker image it would require an arm64 host to build the image

adamrankin commented 3 years ago

Edit: nevermind. I need to learn more.