search

commontk / CTK

A set of common support code for medical imaging, surgical navigation, and related purposes.
https://commontk.org
Apache License 2.0
855 stars 490 forks source link

BUG: Fix ctkDICOMIndexer reverting back to functor signal/slot #1124

Closed jcfr closed 1 year ago

jcfr commented 1 year ago

This commit reverts 7bb0d9fdb (COMP: Fix Qt4/C++98 ctkDICOMIndexerPrivate build using literal signal/slot)

This addresses the following error reported when running ctkDICOMIndexerTest1:

QObject::connect: No such signal QThread::"finished()"
QObject::connect: No such signal ctkDICOMIndexerPrivate::"startWorker()"
QObject::connect: No such signal ctkDICOMIndexerPrivateWorker::"progress(int)"
QObject::connect: No such signal ctkDICOMIndexerPrivateWorker::"progressDetail(QString)"
QObject::connect: No such signal ctkDICOMIndexerPrivateWorker::"progressStep(QString)"
QObject::connect: No such signal ctkDICOMIndexerPrivateWorker::"updatingDatabase(bool)"
QObject::connect: No such signal ctkDICOMIndexerPrivateWorker::"indexingComplete(int,int,int,int)"
QObject::connect: No such signal ctkDICOMIndexer::"indexingComplete(int,int,int,int)"

For reference, the functor-based connection was introduced in 7f2f24a051 (ENH: DICOM browser rework)