COMP: Revert removal of custom CTK Dialog options

commontk / CTK

A set of common support code for medical imaging, surgical navigation, and related purposes.

https://commontk.org

Apache License 2.0

855 stars 490 forks source link

COMP: Revert removal of custom CTK Dialog options #1128

Closed jcfr closed 1 year ago

jcfr commented 1 year ago

This reverts commit 720deca2337f089282a95f2b5ff2e86580213a74 integrated though:

https://github.com/commontk/CTK/pull/1127

Considering that ctkDirectoryButton and ctkPathLineEdit both derive from QWidget and user code may use reference to option like ctkPathLineEdit::ShowDirsOnly (instead of QFileDialog::ShowDirsOnly), this reverts the commit.

jcfr commented 1 year ago

@jamesobutler Until we find a more graceful way to deprecate the older API and avoid breaking current code, do you have any objection if we revert the change and move forward with integrating this pull request ?

jamesobutler commented 1 year ago

Sure you can revert it for now. I'm unable to do the deprecation fixes now, but can look into during my off hours.