commontoolsinc / system

A constellation of Common tools
2 stars 0 forks source link

Do not pipe guest modules to host stdout #77

Open jsantell opened 1 month ago

jsantell commented 1 month ago

Currently, println! in common-javascript-interpreter and console.log in the JS VM are piped to the host's stdout. Unclear what the debugging story looks like in the future, but modules shouldn't be able to pipe to stdout

cdata commented 1 month ago

I would actually prefer to re-frame this as a feature request.

Unclear what the debugging story looks like in the future

This is for us to define. We need logging of some kind, and so will our users.

modules shouldn't be able to pipe to stdout

Correct, but it's important to recognize that we're doing this out of necessity right now, and the need must be met in kind by a useful capability in our programming model.