search

commontorizon / meta-common-torizon

Fork of the TorizonCore OpenEmbedded Distro Layer to create Common TorizonCore
MIT License
10 stars 10 forks source link

auto-provisioning: add service restart for remote access (RAC) #26

Closed EdTheBearded closed 9 months ago

EdTheBearded commented 9 months ago

If we pre-enable RAC and set the image to auto-provision itself, it could be that remote-access.service fails to start due to the fact that the device wasn't provisioned when it checked.

This way, after the device is auto provisioned, it checks if RAC is enabled and if so restarts the service.

EdTheBearded commented 9 months ago

@EdTheBearded this is specific for the common? Not should be added upstream?

Good question. This is not specific for common, I also created the same PR on toradex-torizon. I'm just not sure on how to proceed here. Since this change was triggered due to some customization, we need this here, but this is a improvement shared between both.

Should I drop this PR, merge the one on toradex-torizon and then cherry-pick? What's the usual process?

microhobby commented 9 months ago

Should I drop this PR, merge the one on toradex-torizon and then cherry-pick? What's the usual process?

yeah, I will close this one since the https://github.com/torizon/meta-toradex-torizon/pull/7 was already merged into the upstream.

We before a release always rebase here to follow the upstream work, so we will have this change. Thanks @EdTheBearded