search

commontorizon / meta-common-torizon

Fork of the TorizonCore OpenEmbedded Distro Layer to create Common TorizonCore
MIT License
9 stars 9 forks source link

[Visual Bug] v6.7.0-common has incorrect version string #51

Open bw908 opened 1 week ago

bw908 commented 1 week ago

There is a minor error/visual bug in the version information displayed in the v6.7 image.

I deployed the v6.7.0-common prebuilt image to an RPi 4. The version information is incorrect; the ostree deployment says it is 6.6.0-devel-20240324182453+build.0-tcbuilder.20241007175223

drewmoseley commented 3 days ago

I was able to confirm this. Interesting. I don't think it's just a visual bug though. It seems to me OSTree would have the right version stamp so I wonder if we have a bug in CI or something that creates the release. @jsrc27 @microhobby can you guys comment?

microhobby commented 2 days ago

@drewmoseley @bw908 this image comes from the Github releases or from https://commontorizon.dev/delegations/tdx-common.json ?

drewmoseley commented 2 days ago

From the github releases installed with:

rpi-imager --repo https://github.com/commontorizon/meta-common-torizon/releases/download/v6.7.0-common/os_list_imagingutility.json
microhobby commented 2 days ago

@drewmoseley so, I think that is really only a visual bug. I also introduced a change to have the versioning bumped by us: https://github.com/commontorizon/meta-common-torizon/commit/921cd73c9cd93c4a776ced9bf8492ebad2be251a

Sometimes the upstream had not changed the numbers or was waiting for Toradex BSP, but on our side we had completed the development. This was the case with these builds of v6.7.0 for example.

bw908 commented 2 days ago

Yes, I was using the image downloaded directly from the github releases page when I observed this.