commonwealth-of-puerto-rico / fortaleza

Modules and solutions implemented within the Drupal iteration (yet not limited to Drupal) of the Executive Office of the Governor of Puerto Rico
6 stars 3 forks source link

Button "Ver fotos adicionales" on "Foto del Día" #10

Closed rubenvarela closed 11 years ago

rubenvarela commented 11 years ago

Under _Foto del Día_ there is a button, _Ver fotos adicionales_. This button works under Chrome and Opera, but under Firefox and Safari it doesn't.

Tested on Mac OS X with

If anyone can confirm or try other platforms, it would be great.

jonathanagosto commented 11 years ago

Confirmed in Firefox 21.

I presume from the HTML source that Foto del Día is hard-coded instead of block through the structure blocks system. My suggestion would be to drop the usage of the button tag:

<button class="btn btn-small" type="button">
    <a href="http://www.flickr.com/photos/91802318@N07/ ">Ver fotos adicionales</a>
</button>

and instead use the following line:

<a href="http://www.flickr.com/photos/91802318@N07/" class="btn btn-small">Ver fotos adicionales</a>

Unless you need to run a script or something along those lines, what you want to emulate is the button style, which is provided by the .btn and .btn-small classes.

update: I submitted a patch.

rubenvarela commented 11 years ago

Hey jonathanagosto,

I was on a trip and just got back. I'm installing updates right now, and I'll check* this and your patch!

edit – fixed a typo*