CSS optimizations & Foto del Día fix

commonwealth-of-puerto-rico / fortaleza

Modules and solutions implemented within the Drupal iteration (yet not limited to Drupal) of the Executive Office of the Governor of Puerto Rico

6 stars 3 forks source link

Closed jonathanagosto closed 11 years ago

jonathanagosto commented 11 years ago

Eliminate the button tag in favor of applying the button style to the anchor itself.
Match the styles of the breadcrumbs and the top nav by replacing the image used on top nav with an rgba equivalent (and thus optimizing network).
Search block form change proposal for better positioning and aesthetics. Put it at the same height as the breadcrumbs.

screenshot_saladeprensa_fortaleza_06082013

rfalfaro commented 11 years ago

The idea is to be consistant with the graphic design. Either fixing the button style or replacing by an image (we prefer to have a text link).

jonathanagosto commented 11 years ago

The design stays the same if you get rid of the button tag as long as you apply the "btn btn-small" classes to the anchor.

The other solution is to add a onclick event to the button tag (something I wouldn't recommend in this case).

rubenvarela commented 11 years ago

Commit d8d2c52 – From the testing I've done, the changes to the page.tpl.php work great. Nice and simple solution @jonathanagosto.

Like @jonathanagosto says, the button style is actually in CSS and you can simply add those classes to the anchor tag and have the same look.

Tested on Mac OS 10.8.4 in:

I'll check out the 1770ec3 commit.

jonathanagosto commented 11 years ago

If you have any questions regarding the changes, let me know.