commudle / commudle-ng

Where software developers grow together!
https://commudle.com
GNU Affero General Public License v3.0
130 stars 54 forks source link

Show the link to event session page on public event page after the event has concluded #68

Closed arpansac closed 3 years ago

arpansac commented 4 years ago

Example: https://commudle.com/communities/gdg-new-delhi/events/developer-days-android-day-1 should have a link to the page where the live session was organized. This is the link: https://commudle.com/communities/gdg-new-delhi/events/developer-days-android-day-1/session

sanchit2107 commented 4 years ago

@arpansac Can you Please describe this issue in more detail? So that I can work over it.

Thanks

arpansac commented 4 years ago

Hey @sanchit2107 If you visit this event page: https://commudle.com/communities/gdg-new-delhi/events/developer-days-android-day-1 It should have a link to the page where the users can go and view the session which took place in the past, which is on this link: https://commudle.com/communities/gdg-new-delhi/events/developer-days-android-day-1/session

This event is of the type 'single session'. The multiple session event pages don't have this issue because we display a time table for them.

Let me know if you need screenshots :)

sanchit2107 commented 4 years ago

Okay, @arpansac I got it.

You want to say that the event page: https://commudle.com/communities/gdg-new-delhi/events/developer-days-android-day-1 should be replaced by link through which users can view the past sessions and which is on the link: https://commudle.com/communities/gdg-new-delhi/events/developer-days-android-day-1/session

I hope this is the only one you want to talk about.

If not then please share screenshots.

Thanks .

arpansac commented 4 years ago

Just a little bit different, you almost got it. Let me explain with screenshots

EVENT TYPE 1 [DOESN'T NEED ANY CHANGES]: https://commudle.com/communities/gdg-new-delhi/events/developer-days-1-let-s-learn-angular It has a custom agenda/schedule and even after it gets completed, people can click on the session's link and access the session page. Example image: Screenshot 2020-08-23 at 5 33 52 PM

EVENT TYPE 2 [NEEDS CHANGES]: https://commudle.com/communities/gdg-new-delhi/events/developer-days-android-day-1 This doesn't have a custom agenda, it just has 1 session. But as you can see, there's no way to access that session after the event is completed (this is the link to the session https://commudle.com/communities/gdg-new-delhi/events/developer-days-android-day-1/session).

Here's a description: Screenshot 2020-08-23 at 5 39 24 PM

Also, let me help you with some steps:

Hope this helps, if not, let me know @sanchit2107 !

Eagerly waiting to see your first successful PR here.

arpansac commented 4 years ago

@sanchit2107 are you still interested?

sanchit2107 commented 4 years ago

Dear @arpansac

Actually I have my last semester exams this week. So busy in preparation.

I will start working over it after 08-09-2020 if you don't have any problem.

I hope you understand my concern.

arpansac commented 4 years ago

Absolutely, just let me know once you begin so that I can assign this issue to you.

sanchit2107 commented 4 years ago

Sure thank you!!

arpansac commented 4 years ago

@sanchit2107 did you fix this and forget to push the PR by any chance? :D

arpansac commented 3 years ago

resolved with #98