search

commune-os / weird-legacy

Local-first webpage generator
https://weird-test.krivah.me/
30 stars 7 forks source link

MVP 1 Coordination #21

Open zicklag opened 1 year ago

zicklag commented 1 year ago

Hey there! @erlend-sh brough me here to help out. :D

I got the app building and running locally, and I opened #20 to fix an issue where it was using 100% of 2 CPU cores.

I wanted to ask @krivahtoo what you think would be good for me to work on.

I see that there's some functionality to get working for the user interaction and experience, but I imagine you might be working on that already ( you already fixed the first issue I noticed last night in a40b06ec13efc1938bac6434268181da24f73046 ☺ ).

I was thinking maybe it'd make sense for me to work on the deployment aspect. For now, since we are just deploying a static site, we should be able to work in parallel without stepping on each-other's toes.

We can probably make a simple abstraction so that each deployment backend is responsible for

  1. Taking the dist.zip to deploy.
  2. Collecting the user information for deployment through a backend-specific UI flow.
  3. Deploying the actual artifact using the appropriate provider APIs.

I think doing a streamlined backend for GitHub pages would be a good start. I believe we can make a Weird github app, that will allow us to show the user a "Sign in with GitHub" window. Once they sign-in we can ask them what the repo name should be, and what domain to set it up for, then finally, we'll use the GitHub API to make the deployment and tell them to point their domain to the GitHub pages server.

Any thoughts?

krivahtoo commented 1 year ago

I got the app building and running locally, and I opened https://github.com/commune-os/weird/pull/20 to fix an issue where it was using 100% of 2 CPU cores.

Thanks for the fix, I didn't realize the CPU usage.

I was thinking maybe it'd make sense for me to work on the deployment aspect. For now, since...

Yeah, that would be great. I see you have already started implementing 😊.