search

communi / communi-desktop

An IRC client for desktop environments
https://communi.github.io/
BSD 3-Clause "New" or "Revised" License
57 stars 22 forks source link

make uninstall removes all hicolor icons from the system #101

Closed Venemo closed 9 years ago

Venemo commented 9 years ago

When running sudo make uninstall in communi-desktop's directory the makefile will simply remove all hicolor icons from the system.

Taking a look at the Makefile, it contains the following:

uninstall_icons: FORCE
    -$(DEL_FILE) -r $(INSTALL_ROOT)/usr/share/icons/hicolor/64x64
    -$(DEL_FILE) -r $(INSTALL_ROOT)/usr/share/icons/hicolor/512x512
    -$(DEL_FILE) -r $(INSTALL_ROOT)/usr/share/icons/hicolor/48x48
    -$(DEL_FILE) -r $(INSTALL_ROOT)/usr/share/icons/hicolor/32x32
    -$(DEL_FILE) -r $(INSTALL_ROOT)/usr/share/icons/hicolor/256x256
    -$(DEL_FILE) -r $(INSTALL_ROOT)/usr/share/icons/hicolor/24x24
    -$(DEL_FILE) -r $(INSTALL_ROOT)/usr/share/icons/hicolor/16x16
    -$(DEL_FILE) -r $(INSTALL_ROOT)/usr/share/icons/hicolor/128x128
    -$(DEL_DIR) $(INSTALL_ROOT)/usr/share/icons/hicolor/

A chat with @jpnurmi on IRC reveals that the issue is qmake's excellent understanding of what a wildcard means. Maybe this is also worth reporting against qmake, because I cannot imagine any conveivable scenario when this sort of behaviour is desireable.

Venemo commented 9 years ago

@jpnurmi You're awesome! Thanks for fixing it. :)