search

communi / communi-desktop

An IRC client for desktop environments
https://communi.github.io/
BSD 3-Clause "New" or "Revised" License
57 stars 22 forks source link

Add support for znc.in/message-seen #112

Closed torarnv closed 8 years ago

jpnurmi commented 8 years ago

Could you rebase the PR? I've tweaked the "build base library as shared library" commit so that it works for Linux and Windows, and all other commits have been merged except the last one that adds the messageseen plugin. There's a QScopedValueRollback related build failure on the CI:

compiling messageseenplugin.cpp
messageseenplugin.cpp: In member function ‘virtual bool MessageSeenPlugin::messageFilter(IrcMessage*)’:
messageseenplugin.cpp:150:73: error: no matching function for call to ‘QScopedValueRollback<bool>::QScopedValueRollback(bool&, bool)’
     QScopedValueRollback<bool> rollback(m_processingMsgSeenMessage, true);
                                                                         ^
messageseenplugin.cpp:150:73: note: candidates are:
In file included from /usr/include/qt5/QtCore/qnamespace.h:45:0,
                 from /usr/include/qt5/QtCore/qobjectdefs.h:45,
                 from /usr/include/qt5/QtCore/qobject.h:48,
                 from /usr/include/qt5/QtCore/QObject:1,
                 from messageseenplugin.h:32,
                 from messageseenplugin.cpp:29:
/usr/include/qt5/QtCore/qscopedvaluerollback.h:73:20: note: QScopedValueRollback<T>::QScopedValueRollback(const QScopedValueRollback<T>&) [with T = bool]
     Q_DISABLE_COPY(QScopedValueRollback)
                    ^
/usr/include/qt5/QtCore/qglobal.h:978:5: note: in definition of macro ‘Q_DISABLE_COPY’
     Class(const Class &) Q_DECL_EQ_DELETE;\
     ^
/usr/include/qt5/QtCore/qscopedvaluerollback.h:73:20: note:   candidate expects 1 argument, 2 provided
     Q_DISABLE_COPY(QScopedValueRollback)
                    ^
/usr/include/qt5/QtCore/qglobal.h:978:5: note: in definition of macro ‘Q_DISABLE_COPY’
     Class(const Class &) Q_DECL_EQ_DELETE;\
     ^
In file included from messageseenplugin.cpp:39:0:
/usr/include/qt5/QtCore/qscopedvaluerollback.h:53:14: note: QScopedValueRollback<T>::QScopedValueRollback(T&) [with T = bool]
     explicit QScopedValueRollback(T &var) :
              ^
/usr/include/qt5/QtCore/qscopedvaluerollback.h:53:14: note:   candidate expects 1 argument, 2 provided
moc commandverifier.h
make[3]: *** [release/messageseenplugin.o] Error 1
make[3]: Leaving directory `/home/travis/build/jpnurmi/communi-desktop/src/plugins/messageseen'
make[2]: *** [sub-messageseen-make_first] Error 2

The CI is Ubuntu 14.04.3 LTS, Qt 5.2.1, GCC 4.8.4, Clang 3.5.0.