search

communi / communi-desktop

An IRC client for desktop environments
https://communi.github.io/
BSD 3-Clause "New" or "Revised" License
57 stars 22 forks source link

Use QStandardPaths::writableLocation(AppDataLocation) for logs #128

Closed jpnurmi closed 7 years ago

jpnurmi commented 7 years ago

Don't spam the home directory, but query QStandardPaths for the appropriate OS-dependent application data directory for storing the logs.

/cc @anselmolsm @Venemo

anselmolsm commented 7 years ago

👍

anselmolsm commented 7 years ago

Notice this bumps the required Qt version to 5.4, which introduced AppDataLocation.

Venemo commented 7 years ago

@jpnurmi @anselmolsm Are we sure that we want to bump the required Qt version just for this?

Which versions are we targeting exactly? IIRC last time we talked about this (which was a long time ago) it was still an objective to support Qt4 as well. Is that still the case?

jpnurmi commented 7 years ago

libcommuni is used by some Qt 4 -based projects that have asked us to keep Qt 4 support for as long as possible. communi-desktop, however, can depend on any Qt version that we think is reasonable. According to https://en.wikipedia.org/wiki/Qt_version_history Qt 5.4 was released in December 2014, so I don't mind bumping up the required version to Qt 5.4. On the other hand, we could use QStandardPaths::DataLocation on Qt < 5.4. Thoughts?

Venemo commented 7 years ago

@jpnurmi So the Qt4 stuff is only meant for libcommuni, and not communi-desktop? That sounds reasonable. I also agree on the solution for <5.4

anselmolsm commented 7 years ago

The solution for Qt<5.4 sounds good enough for now.