search

communi / communi-desktop

An IRC client for desktop environments
https://communi.github.io/
BSD 3-Clause "New" or "Revised" License
57 stars 22 forks source link

Follow channel links #137

Closed nib952051 closed 6 years ago

nib952051 commented 6 years ago

Probably targets issue https://github.com/communi/communi-desktop/issues/7

jpnurmi commented 6 years ago

Thanks! I've been overly busy lately, but I'll try to find some time to check the patch the upcoming days!

jpnurmi commented 6 years ago

It would be also nice to activate the channel if already on it. ;) Actually, would it make sense to have it as a menu similarly to nick links, so ther could be multiple actions in the future? This could be done as follow-up commits later, though, but it would be nice to hear first what you think.

nib952051 commented 6 years ago

both requests are fine with me I will try to look how to implement them. I would like to continue commiting to this PR, given that PR might be squashed and merged

I found tests but looks like they are outdated and they live in another repo. May I continue without test?:)

And I will fix travis builds

jpnurmi commented 6 years ago

Sure, that's fine. I can also help :)