search

communi / communi-sailfish

The first and foremost IRC client for Sailfish OS
BSD 3-Clause "New" or "Revised" License
38 stars 18 forks source link

Duplicate self messages when connecting to a bouncer (ZNC) #137

Closed rdrms closed 5 years ago

rdrms commented 6 years ago

Don't know if this is for communi-sailfish or would be better raised in the main libcommuni github

Steps to reproduce:

  1. Connect to ZNC
  2. Send a message
  3. Message sends, and then communi receives that message again from the bouncer, showing duplicate messages

This doesn't seem to be related to having another client connected to ZNC, I closed weechat on my computer and was still getting duplicate self messages.

Workaround:

  1. Ignore your own nick Messages still show up from you but you don't get a duplicate.
rdrms commented 6 years ago

I downloaded communi-desktop from the AUR on my Arch desktop, and it doesn't have this problem. So it looks to be an issue with the Sailfish version.

rdrms commented 6 years ago

should note that this only happens with the openrepos version. The Jolla store version works fine. I'd really like to use the more updates ans featureful openrepos version though.

Venemo commented 6 years ago

Why do you use the openrepos version? IIRC we never uploaded this app to openrepos, and am not sure who did.

rdrms commented 6 years ago

Sorry I just found it first. The Jolla store version works fine, I’ll use that. One question though, for one of my servers (Freenode) the user list is unavailable in all channels. On my other ZNC server (Rizon) the user list works fine, the lack of user list on freenode is why I thought the openrepo version was better. Do you think this is an issue with my ZNC settings, or communi’s?

Thaodan commented 6 years ago

@Venemo thats my upload. I think there's some regression here. The buffer playback it self don't works really.

Venemo commented 6 years ago

Sorry @Thaodan I meant no offence to you. Which version did you upload? I will try to take a look at the state of communi-sailfish and see what is going on. I've been wanting to get to it for some time. Sorry for the delay.

Thaodan commented 6 years ago

No problem. Look at my fork here. The branch that it's on obs/openrepos is lyro_merge. I suspect some changes in the core of communi that broke the app

Am 12. September 2018 11:23:20 MESZ schrieb "Timur Kristóf" notifications@github.com:

Sorry @Thaodan I meant no offence to you. Which version did you upload? I will try to take a look at the state of communi-sailfish and see what is going on. I've been wanting to get to it for some time. Sorry for the delay.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/communi/communi-sailfish/issues/137#issuecomment-420576428

Venemo commented 6 years ago

Thanks @Thaodan I will probably be able to take a look next week.

Thaodan commented 6 years ago

I suspect some changes in the shared module.

Thaodan commented 5 years ago

Should be fixed by: https://github.com/communi/communi-sailfish/commit/275a777c4b61b17ae02ab849f85c1f9711c09f90

Thaodan commented 5 years ago

Fixed by https://github.com/communi/communi-sailfish/commit/275a777c4b61b17ae02ab849f85c1f9711c09f90