communi / communi-sailfish

The first and foremost IRC client for Sailfish OS
BSD 3-Clause "New" or "Revised" License
37 stars 18 forks source link

[BUG] Notifications have no timestamp and always appear as if they were send right now #191

Closed Thaodan closed 2 years ago

Thaodan commented 2 years ago

Notifications don't set a timestamp right now which means they implicitly have the same timestamp as when the notification is created. The issue with that the timestamp from the notification is out of line with the timestamp of the message itself. There's a potential disconnect in the timestamp of regular messages. In case of playbacks the timestamp will always be wrong the timestamp set on the message isn't used. This especially important when the IRCv3 extension server-time is used.

Proposed change to fix this:

Thaodan commented 2 years ago

Fixed in https://github.com/communi/communi-sailfish/commit/53035a3e6b3d323ecfd19b43c5b1076d428202ce.