Add an option to drop connections to IrcLagTimer

communi / libcommuni

A cross-platform IRC framework for Qt

https://communi.github.io

BSD 3-Clause "New" or "Revised" License

84 stars 37 forks source link

Add an option to drop connections to IrcLagTimer #111

Closed mornfall closed 1 year ago

mornfall commented 1 year ago

It makes sense to drop a (sufficiently) dead connection, so make that easy. It would also allow a simple workaround for sailfish-communi missing connection events and getting stuck forever. I'll send a draft PR for the sailfish-communi half of this in a bit.

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging 2da343e343be1f39e4f0bcb887ab62c077fa6624 into d1625e5d667503df3ee2ddd156f2ad6d7ed3f1a2 - view on LGTM.com

new alerts:

1 for FIXME comment

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging 13b6a84a1212e6a39b042d83f31ffdddabf71500 into d1625e5d667503df3ee2ddd156f2ad6d7ed3f1a2 - view on LGTM.com

new alerts:

1 for FIXME comment

Thaodan commented 1 year ago

To add some context why this PR was closed: I asked that the contributor to have a clean commit history if possible, not commit to master and have one branch PR. After that he told me I should do that, I told him no and he closed this PRs after.