communi / libcommuni

A cross-platform IRC framework for Qt
https://communi.github.io
BSD 3-Clause "New" or "Revised" License
83 stars 37 forks source link

Translation / internationalisation / localisation #65

Closed Kebap closed 4 years ago

Kebap commented 5 years ago

So we are using libcommuni as part of the Mudlet game client.

As we are localizing Mudlet, we are also looking at your strings, and find some hard to grasp.

Examples:

  1. ! %2 invited to %3
  2. ! %1 sets mode %2 %3 %4
  3. * %1 %2

Have you maybe already come up with a set of translations?

Indeed for many of these strings it would probably have been better to have used a QStringLiteral instead of tr as they are assembling a sentence in chunks and that usually does not fly well with i18n. Without further knowledge of what each replacement value is, it is not clear that translation is going to work here.

What work has been done to internationalise the libcommuni project...? How should we report our (tries at) translations back upstream to you?

jpnurmi commented 5 years ago

Hi, are you referring to the code in libcommuni examples? It was meant to be used as a rough starting point for products that may want to use i18n.

Kebap commented 5 years ago

Thanks jpnurmi, this has clarified the issue a bit. I will look into it more and see how to fix the matter then.